Updates to Segmentation catalog to increase source detection #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
…est source fraction"
limits which were misleading, and added a new variable name to accommodate the RickerWavelet
biggest source limit.
OLD NEW
_rw2d_biggest_source ==> _biggest_source_limit
_rw2d_source_fraction ==> _biggest_source_fraction_limit
new ==> _rw_biggest_source_limit
These changes required updating the catalog parameter JSON files, the code which reads
the parameter values, and parameter names in segmentation source support functions.
Clarified informational log messages when reporting the configuration limits in use for
the Segmentation catalog. Moved the computation of the ratio between the "Gaussian
biggest source" and the "Rickerwavlet biggest source" to be computed, as well as applied,
for Round 2. Added more informational messages to keep the user better informed. Changed
some limit values (though more changes will be needed for other detectors):
ACS/WFC ONLY
negative_percent: 15.0 ==> 20.0
rw2d_nsigma: 10.0 ==> 40.0
mdlpstsci
force-pushed
the
catsAndCrowdedFields
branch
from
c4b7ff8
to
64cfcbb
Compare
raswaters
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes associated with Jira HLA-1004.
Changed the variable names for the general "biggest source" and "biggest source fraction" limits which were misleading, and added a new variable name to accommodate the RickerWavelet biggest source limit.
OLD NEW
_rw2d_biggest_source ==> _biggest_source_limit
_rw2d_source_fraction ==> _biggest_source_fraction_limit
new ==> _rw_biggest_source_limit
These changes required updating the catalog parameter JSON files, the code which reads the parameter values, and parameter names in segmentation source support functions.
Clarified informational log messages when reporting the configuration limits in use for the Segmentation catalog. Moved the computation of the ratio between the "Gaussian biggest source" and the "Rickerwavlet biggest source" to be computed, as well as applied, for Round 2. Added more informational messages to keep the user better informed. Changed some limit values (though more changes will be needed for other detectors):
ACS/WFC ONLY
negative_percent: 15.0 ==> 20.0
rw2d_nsigma: 10.0 ==> 40.0