Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drizzlepac: Updated PyTest test_svm_hrcsbc.py from causing failure on PR #1639

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

mdlpstsci
Copy link
Collaborator

Updated PyTest test_svm_hrcsbc.py after testing on Linux, MacOS, and examining archive files. After this work was done, it was justified to change the number of sources found in the SBC image(s).

@mdlpstsci mdlpstsci self-assigned this Aug 11, 2023
@mdlpstsci mdlpstsci requested a review from a team as a code owner August 11, 2023 15:19
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (2f1f7bc) 32.40% compared to head (c324fdc) 32.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1639      +/-   ##
==========================================
- Coverage   32.40%   32.39%   -0.01%     
==========================================
  Files         159      159              
  Lines       35047    35045       -2     
==========================================
- Hits        11357    11353       -4     
- Misses      23690    23692       +2     
Files Changed Coverage Δ
tests/hap/test_svm_hrcsbc.py 91.17% <100.00%> (-0.13%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdlpstsci
Copy link
Collaborator Author

This PR is just a change to a single value, a clean of two lines of code, and a clarifying comment.

@mdlpstsci mdlpstsci merged commit ac10b99 into spacetelescope:master Aug 12, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant