Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLA-1192: GitHub branch rename master to main #1725

Conversation

s-goldman
Copy link
Collaborator

@s-goldman s-goldman commented Jan 29, 2024

Resolves HLA-1192

Closes #

This PR addresses references to the master branch in the repository. The one reference has been changed to "main".

Checklist for maintainers

  • added entry in CHANGELOG.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR

Jenkins test

@s-goldman s-goldman requested review from mdlpstsci and a team as code owners January 29, 2024 19:04
@s-goldman
Copy link
Collaborator Author

@mdlpstsci This change only affects a line in the HapDiagnostic json file, specifically self.out_dict['general information']['commit id'] changed in the code diagnostic_utils.py here.

Other than this change, are there any other changes in HSTCal or other packages that may be affected by the change of the remote branch name from master to main?

I am following the instructions listed here

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fc546c6) 36.58% compared to head (ac136b2) 31.10%.

❗ Current head ac136b2 differs from pull request most recent head 6574e3d. Consider uploading reports for the commit 6574e3d to get more accurate results

Files Patch % Lines
drizzlepac/haputils/get_git_rev_info.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1725      +/-   ##
==========================================
- Coverage   36.58%   31.10%   -5.49%     
==========================================
  Files         159      159              
  Lines       35120    35102      -18     
  Branches     5710        0    -5710     
==========================================
- Hits        12849    10918    -1931     
- Misses      21887    24184    +2297     
+ Partials      384        0     -384     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdlpstsci
Copy link
Collaborator

@s-goldman
As far as I know the impact of the change will be for people who are working on this repo. They will need to refresh their clones.

@s-goldman s-goldman merged commit 385c29e into spacetelescope:main Feb 15, 2024
14 of 15 checks passed
@s-goldman s-goldman deleted the hla-1192_github_branch_master_to_main_01_29_24 branch February 15, 2024 15:51
mdlpstsci pushed a commit to mdlpstsci/drizzlepac that referenced this pull request Feb 21, 2024
Co-authored-by: codesee-maps[bot] <86324825+codesee-maps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants