include Python versions in toxenvs, install HDF5 for macOS tests #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyburnett
changed the title
zacharyburnett
commented
Apr 29, 2024
Comment on lines
+34
to
+36
| libraries: | | ||
| brew: | ||
| - hdf5 |
There was a problem hiding this comment.
this tells the OpenAstronomy workflow to call
brew install hdf5
before attempting to build with pip
|
I'll also have to change the Required Status Checks when merging this (they've been renamed here) |
|
@zacharyburnett |
mdlpstsci
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use reusable workflow and make toxenv names explicit w/ Python version
Checklist for maintainers
CHANGELOG.rstwithin the relevant release sectionHow to run regression tests on a PR