Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLA-935: Update HDRTAB for MVM Products #1796

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

s-goldman
Copy link
Collaborator

@s-goldman s-goldman commented May 7, 2024

Resolves HLA-935

This PR adds two new header keywords to MVM drizzled (drc/z) products. These include the name (SVMINPUT) and creation date (DATE-SVM) of each of the SVM images included within the MVM. These are inserted into the zeroth extension header for each of the filter-level products. These are listed high up in the header table (as requested) and can be fairly long (see image). The names and location of these keywords can easily be altered.

Screenshot 2024-05-07 at 4 31 29 PM

TODO: I'm still working on some unit tests for this code using unnittest.mock, but the requirement that a file has to be opened has made this challenging. I will likely use the sample_svm files within the test/hap directory.

Checklist for maintainers

  • added entry in CHANGELOG.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR

@s-goldman s-goldman added enhancement Do Not Merge PR which should not be merged and removed Do Not Merge PR which should not be merged labels May 7, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 78.04878% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 31.76%. Comparing base (76a3e27) to head (69f00db).

Files Patch % Lines
drizzlepac/haputils/processing_utils.py 70.83% 7 Missing ⚠️
drizzlepac/hapmultisequencer.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1796      +/-   ##
==========================================
- Coverage   33.31%   31.76%   -1.55%     
==========================================
  Files         126      160      +34     
  Lines       31197    35203    +4006     
  Branches     5772        0    -5772     
==========================================
+ Hits        10392    11182     +790     
- Misses      19642    24021    +4379     
+ Partials     1163        0    -1163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s-goldman s-goldman marked this pull request as ready for review May 8, 2024 19:37
@s-goldman s-goldman requested review from mdlpstsci and a team as code owners May 8, 2024 19:37
Copy link
Collaborator

@mdlpstsci mdlpstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This HLA-935 ticket has been misinterpreted. Please see the Jira ticket for an explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants