New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLA-935: Update HDRTAB for MVM Products #1796
base: main
Are you sure you want to change the base?
HLA-935: Update HDRTAB for MVM Products #1796
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1796 +/- ##
==========================================
- Coverage 33.31% 31.76% -1.55%
==========================================
Files 126 160 +34
Lines 31197 35203 +4006
Branches 5772 0 -5772
==========================================
+ Hits 10392 11182 +790
- Misses 19642 24021 +4379
+ Partials 1163 0 -1163 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This HLA-935 ticket has been misinterpreted. Please see the Jira ticket for an explanation.
Resolves HLA-935
This PR adds two new header keywords to MVM drizzled (drc/z) products. These include the name (SVMINPUT) and creation date (DATE-SVM) of each of the SVM images included within the MVM. These are inserted into the zeroth extension header for each of the filter-level products. These are listed high up in the header table (as requested) and can be fairly long (see image). The names and location of these keywords can easily be altered.
TODO: I'm still working on some unit tests for this code using unnittest.mock, but the requirement that a file has to be opened has made this challenging. I will likely use the sample_svm files within the test/hap directory.
Checklist for maintainers
CHANGELOG.rst
within the relevant release sectionHow to run regression tests on a PR