HLA-1138: Exclude single filter images in the generation of the total detection image #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdlpstsci
added
feature request
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1797 +/- ##
==========================================
- Coverage 33.30% 31.45% -1.85%
==========================================
Files 126 160 +34
Lines 31187 35166 +3979
Branches 5770 0 -5770
==========================================
+ Hits 10386 11061 +675
- Misses 19640 24105 +4465
+ Partials 1161 0 -1161 ☔ View full report in Codecov by Sentry. |
rlwastro
requested changes
May 13, 2024
drizzlepac/haputils/product.py
Outdated
Comment on lines
667
to
675
| set_of_filters = set([element.filters for element in self.edp_list]) | ||
| count_dict = {key: [] for key in set_of_filters} | ||
|
|
||
| # Loop over the exposure objects to collect the exposures for each filter | ||
| for expo in self.edp_list: | ||
| for key in count_dict: | ||
| if key == expo.filters: | ||
| count_dict[key].append(expo.full_filename) | ||
| break |
There was a problem hiding this comment.
Suggested change
| set_of_filters = set([element.filters for element in self.edp_list]) | |
| count_dict = {key: [] for key in set_of_filters} | |
| # Loop over the exposure objects to collect the exposures for each filter | |
| for expo in self.edp_list: | |
| for key in count_dict: | |
| if key == expo.filters: | |
| count_dict[key].append(expo.full_filename) | |
| break | |
| count_dict = {} | |
| # Loop over the exposure objects to collect the exposures for each filter | |
| for expo in self.edp_list: | |
| count_dict.set_default(expo.filters,[]).append(expo.full_filename)) |
I think the current code is much more complicated than it needs to be. I removed the set_of_filters variable because I think it is not used elsewhere. If I'm wrong about that, it can be computed from count_dict after the loop.
There was a problem hiding this comment.
Indeed. I am not very Pythonic in my thinking. Also, I forgot that by definition, a dictionary is comprised of a set of unique keys!
image to minimize cosmic ray contamination, unless there are only single filter images in the visit.
added a log message as suggested during the code review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves [HLA-1138(https://jira.stsci.edu/browse/HLA-1138)
Closes #
This PR addresses ...
Exclude single filter images in the generation of the total detection
image to minimize cosmic ray contamination, unless there are only single filter images in the visit.
Checklist for maintainers
CHANGELOG.rstwithin the relevant release sectionHow to run regression tests on a PR