HLA-1254: Address issues caught by SonarQube #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrometric_utils.py/extract_sources(). Removed parameter from any calling functions.
mdlpstsci
added
bug
code cleanup
as the variable is a parameter which can be set by the invoking routine (though it is NOT at this time) or the parameter defaults to None.
output value. It was essentially ignored by the other routines in drizzlepac as an input value.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1802 +/- ##
==========================================
- Coverage 33.32% 31.45% -1.88%
==========================================
Files 126 160 +34
Lines 31204 35168 +3964
Branches 5777 0 -5777
==========================================
+ Hits 10398 11061 +663
- Misses 19643 24107 +4464
+ Partials 1163 0 -1163 ☔ View full report in Codecov by Sentry. |
mdlpstsci
changed the title
zacharyburnett
approved these changes
May 22, 2024
There was a problem hiding this comment.
LGTM, the sonarscan against this branch succeeds and lets the regtests run:
https://github.com/spacetelescope/RegressionTests/actions/runs/9191698890/job/25279150673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves HLA-1254
Closes #
This PR addresses ...
Address issues caught by SonarQube statis code analysis. This must be done according to ITSD requirements.
Deleted the deprecated parameter, dao_threshold, in
astrometric_utils.py/extract_sources(). Removed parameter from any calling functions.
Checklist for maintainers
CHANGELOG.rstwithin the relevant release sectionHow to run regression tests on a PR