Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLA-1265: Streamline some regression tests #1811

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

mdlpstsci
Copy link
Collaborator

@mdlpstsci mdlpstsci commented Jun 10, 2024

Resolves HLA-1265

Closes #

This PR streamlines some regression tests which were designed to work on large numbers of datasets to generate statistics in order to prove the HAP project should proceed. These tests are kept for historic reasons and only need to be kept up-to-date so they can execute as necessary.

Removed template_svm_demo.py as it was really a template which was superseded by the real test file, test_svm_je281u.py. Changed the default number of datasets to process for the "large" statistical tests to "1" (down from "5") as the test are taking a long time to run. Simplified how an ascii file containing filenames is read (test_run_svmpoller.py).

Checklist for maintainers

  • added entry in CHANGELOG.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR

superseded by the real test file, test_svm_je281u.py.  Changed the
default number of datasets to process for the "large" statistical
tests to "1" (down from "5") as the test are taking a long time to
run.  Simplified how an ascii file containing filenames is read
(test_run_svmpoller.py).
@mdlpstsci mdlpstsci added testing code cleanup Code refactoring, cleanup of temporary code jirahub-ignore Avoid linking to Jira labels Jun 10, 2024
@mdlpstsci mdlpstsci self-assigned this Jun 10, 2024
@mdlpstsci mdlpstsci requested a review from a team as a code owner June 10, 2024 20:26
@mdlpstsci mdlpstsci changed the title Streamline some regression tests HLA-1265: Streamline some regression tests Jun 10, 2024
@mdlpstsci mdlpstsci requested a review from jhunkeler June 10, 2024 20:30
Copy link
Contributor

@jhunkeler jhunkeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xdist worker issue persists on the runner, but still, the change from Table to plain text makes things easier to understand.

@jhunkeler jhunkeler merged commit f12df02 into spacetelescope:main Jun 14, 2024
13 of 15 checks passed
mdlpstsci added a commit to mdlpstsci/drizzlepac that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Code refactoring, cleanup of temporary code jirahub-ignore Avoid linking to Jira testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants