Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move environment variable declaration into env_vars list #1814

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

jhunkeler
Copy link
Contributor

@jhunkeler jhunkeler commented Jun 13, 2024

The sparse implementation of the BuildConfig class in testenv's groovy "accessor" does not include the runtime list member.

Applying environment variables...
Traceback (most recent call last):
  File "***/local/miniforge3/envs/TEMPORARY/bin/testenv", line 33, in <module>
    sys.exit(load_entry_point('testenv', 'console_scripts', 'testenv')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "***/testenv/testenv/cli/main.py", line 135, in main
    context = TestContext(pkg)
              ^^^^^^^^^^^^^^^^
  File "***/testenv/testenv/testcontext.py", line 108, in __init__
    self.apply_env_vars()
  File "***/testenv/testenv/testcontext.py", line 191, in apply_env_vars
    key, value = var.split('=')

The real error was:

$ groovy testenv/scripts/jfile_accessor.groovy REPO/JenkinsfileRT test_cmds
Caught: groovy.lang.MissingPropertyException: No such property: env for class: JenkinsfileRT
groovy.lang.MissingPropertyException: No such property: env for class: JenkinsfileRT
        at JenkinsfileRT.run(JenkinsfileRT:6)

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.23%. Comparing base (92cfb36) to head (4f40946).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1814      +/-   ##
==========================================
- Coverage   33.18%   31.23%   -1.95%     
==========================================
  Files         126      159      +33     
  Lines       31164    35046    +3882     
  Branches     5778        0    -5778     
==========================================
+ Hits        10341    10946     +605     
- Misses      19654    24100    +4446     
+ Partials     1169        0    -1169     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* bc2 was the intended target
@mdlpstsci mdlpstsci merged commit 6c09075 into spacetelescope:main Jun 13, 2024
14 of 16 checks passed
mdlpstsci pushed a commit to mdlpstsci/drizzlepac that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants