TST: Fix lightkurve 2.0.x compat, improve test header

[pllim]

Looks like lightkurve finally changed their API.

Also add additional dependencies to test header.

TODO

• How to handle LightkurveDeprecationWarning: The PDCSAP_FLUX function is deprecated lightkurve/lightkurve#985 ?
• How to handle What is the un-deprecated equivalent of this search_lightcurvefile call? lightkurve/lightkurve#986 ?
• How to handle LightkurveDeprecationWarning: The SAP_FLUX function is deprecated lightkurve/lightkurve#987 ?
• How to handle UserWarning: dropping mask in Quantity column 'flux': masked Quantity not supported lightkurve/lightkurve#988 (dev job)? See TST: Handle UserWarning in dev job #52

[codecov]

Codecov Report

Merging #50 (860b139) into master (ede22fb) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   79.96%   80.00%   +0.03%     
==========================================
  Files          18       18              
  Lines        1188     1190       +2     
==========================================
+ Hits          950      952       +2     
  Misses        238      238              

Impacted Files	Coverage Δ
conftest.py	100.00% <100.00%> (ø)
exovetter/lightkurve_utils.py	72.72% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede22fb...860b139. Read the comment docs.

[pllim]

I am not sure if this is completely correct fix, though it does make the test pass again.

[mustaric]

I guess ideally we would like to make sure that flat.flux persists as a quantiity instead of as a float. So I think this line should be
from astropy import units as u
flat.flux = flat.flux.value - 1.0) * u.electron/u.electron
The units will be dimensionless, there may be a better way to assign dimensionless units.
(The units returned by lk.flatten are actually incorrect.)

[pllim]

Does the math of minus 1 e and then divided by 1 e make sense? What if somehow another input has flux in Jy? Then, what?

[pllim]

In the tag up today, Susan and I agreed to leave this as-is for now as not to change the currently behavior.

[mustaric]

I think these changes to make it work with lightkurve 2.0 look good. I can't comment on the test header part. I suggested one change to how to do the flatten -1 in that it starts as a quantity, so it should probably end as a quantity, but that quantity should be dimensionless. I doubt it will break anything if we don't make this change.

[mustaric]

As I was playing I realize that we still need to update vetters.ModShift to use
time, flux, time_offset_str =
lightkurve_utils.unpack_lk_version(lc, self.lc_name)
This code was written so wecould go back and forth between new and old lightkurve, but apparently it wasn't implemented for ModShift. Do you want to do that as part of this pull request, or should I open a new one?

[pllim]

go back and forth between new and old lightkurve

I am 👎 on this. Given that corazon already uses lightkurve 2.0, I don't see a real need for such compatibility layer. It is only going to increase maintenance burden. Why do you still need lightkurve 1.0?

[mustaric]

This compatibility layer already exists. I wrote it so I could work with corazon and lightkurve at the same time. It seems to me the easiest path forward is to just make ModShift use the same layer and we can phase it out once we are sure everything is working correctly with lightkurve 2.0. I have no plans to long term support it, but since we already do, it is more work to take it out.

[pllim]

I don't have time to work on this today or the next few days, so feel free to fix modshift if you want. Thanks!

[pllim]

As per tag up today, I will wait till Susan applied her modshift changes before wrapping this up, to avoid conflict.

[mustaric]

I think this is ready to go. Merge when you are ready. I'd officially approve it, but I can't find the github button.

[pllim]

Thanks! I merged it. I'll open a separate issue for the dev job as it is pending reply from Geert.