Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make bounding-box optional #289

Merged
merged 2 commits into from Mar 24, 2020
Merged

make bounding-box optional #289

merged 2 commits into from Mar 24, 2020

Conversation

nden
Copy link
Collaborator

@nden nden commented Mar 23, 2020

This is a simple PR which implements what we discussed already - making the bounding-box optional in to_fits_sip.
There's also a docstring update to an unrelated function.

@nden nden added this to the 0.13 milestone Mar 23, 2020
@coveralls
Copy link

coveralls commented Mar 23, 2020 •
edited

Coverage Status

Coverage increased (+0.06%) to 91.295% when pulling 2ced523 on nden:optional-bbox into bd16c4e on spacetelescope:master.

perrygreenfield
perrygreenfield approved these changes Mar 24, 2020
View reviewed changes
Copy link
Collaborator

@perrygreenfield perrygreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nden nden merged commit cdcd75f into spacetelescope:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrygreenfield perrygreenfield perrygreenfield approved these changes

Assignees
No one assigned
Labels
no_change_log_entry_needed
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nden @coveralls @perrygreenfield