Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not assume model bounding boxes can be cast to numpy arrays #331

Merged
merged 5 commits into from
Dec 18, 2020
Merged

Do not assume model bounding boxes can be cast to numpy arrays #331

merged 5 commits into from
Dec 18, 2020

Conversation

Cadair
Copy link
Collaborator

@Cadair Cadair commented Nov 19, 2020 •
edited by nden

When creating a 2D tabular forward transform using quantities for the LUT and the points the bounding box calculation would fail

Resolves #318

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 91.143% when pulling b59a590 on Cadair:model_bbox into 7e2dbea on spacetelescope:master.

@nden nden added this to the 0.16 milestone Dec 18, 2020
@nden nden merged commit c676cdf into spacetelescope:master Dec 18, 2020
@Cadair Cadair deleted the model_bbox branch December 18, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.

Not possible to set bounding box to values with units
3 participants
@Cadair @coveralls @nden