wcs_from_points inverse fit and interface changes #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cshanahan1 Please add a change log entry under 0.17.0 |
cshanahan1
force-pushed
the
wcsfrompoint_fixes
branch
from
96aad8e
to
6cc654c
Compare
Closed
This was referenced Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the interface to wcs_from_points to better match the similar function in astropy, and added the fitting of the inverse transform.
After discussion with @nden, we decided to not allow a WCS to be passed in to be refit (as is done in astropy - 'projection' can be a projection code or a WCS). Additionally, in astropy a string projection code is supplied but here a projection type is used.