Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in the check for divergence in _fit_2D_poly #414

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

mcara
Copy link
Member

@mcara mcara commented Jul 25, 2022

prev_max_error was not updated ever and if max_resid > prev_max_error: was always False. This effectively turned off checking for divergence.

@mcara mcara added this to the 0.19 milestone Jul 25, 2022
@mcara mcara self-assigned this Jul 25, 2022
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #414 (8bcce47) into master (e15e4d4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #414   +/-   ##
=======================================
  Coverage   86.82%   86.83%           
=======================================
  Files          23       23           
  Lines        3758     3759    +1     
=======================================
+ Hits         3263     3264    +1     
  Misses        495      495           
Impacted Files Coverage Δ
gwcs/wcs.py 87.80% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e15e4d4...8bcce47. Read the comment docs.

@mcara mcara force-pushed the fix-devergence-check-poly2D-fit branch from 995580f to 8bcce47 Compare July 25, 2022 04:17
Copy link
Collaborator

@perrygreenfield perrygreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but way too many lines of code to review ;-) (i.e., anything more than 0)

@nden nden merged commit 9f08a6d into spacetelescope:master Jul 26, 2022
@mcara
Copy link
Member Author

mcara commented Jul 26, 2022

LGTM, but way too many lines of code to review ;-) (i.e., anything more than 0)

Sorry!

@nden nden modified the milestones: 0.19, 0.18.4 Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants