Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pixel scale formula used by iterative inverse #423

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

mcara
Copy link
Member

@mcara mcara commented Sep 27, 2022

Fixes #416

This PR correct the formula for estimating pixel scale in the code for the iterative computation of the inverse coordinate transformation.

@mcara mcara added the bug label Sep 27, 2022
@mcara mcara added this to the 0.19 milestone Sep 27, 2022
@mcara mcara self-assigned this Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 86.83% // Head: 86.83% // No change to project coverage 👍

Coverage data is based on head (fb74fd2) compared to base (f6098a6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #423   +/-   ##
=======================================
  Coverage   86.83%   86.83%           
=======================================
  Files          23       23           
  Lines        3759     3759           
=======================================
  Hits         3264     3264           
  Misses        495      495           
Impacted Files Coverage Δ
gwcs/wcs.py 87.80% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@perrygreenfield perrygreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcara mcara merged commit f4ff623 into spacetelescope:master Sep 27, 2022
@nden nden modified the milestones: 0.19, 0.18.4 Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in wcs.py
3 participants