Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor for Tox 4 #428

Merged
merged 5 commits into from
Dec 12, 2022
Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Dec 12, 2022

update tox.ini and also update version of used GitHub Actions

@zacharyburnett zacharyburnett self-assigned this Dec 12, 2022
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 86.83% // Head: 86.84% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9bdf3fc) compared to base (f4ff623).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   86.83%   86.84%           
=======================================
  Files          23       24    +1     
  Lines        3759     3769   +10     
=======================================
+ Hits         3264     3273    +9     
- Misses        495      496    +1     
Flag Coverage Δ
unit 86.84% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
gwcs/spectroscopy.py 97.79% <0.00%> (+0.13%) ⬆️
gwcs/selector.py 92.94% <0.00%> (+0.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett zacharyburnett marked this pull request as ready for review December 12, 2022 16:05
Copy link
Member

@mcara mcara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what I am approving but if tests pass, that's fine with me

Copy link
Contributor

@WilliamJamieson WilliamJamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names of CI jobs have changed, which means the required jobs will need to be updated.

LGTM

@zacharyburnett zacharyburnett merged commit dfef3f1 into spacetelescope:master Dec 12, 2022
@zacharyburnett zacharyburnett deleted the tox_4 branch December 12, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants