Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add on spring cleaning #486

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Add on spring cleaning #486

wants to merge 22 commits into from

Commits on Oct 12, 2023

  1. Define and document the core CoordinateFrame API 

    This creates a `BaseCoordinateFrame` class, definining the minimal API
for a coordinate frame with descriptive docstrings. This is done mainly
as an exercise to easily review and document the API. Also add
significant docstring to the module describing how and why coordinate
frames work.
    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    f0dcb4f View commit details
    Browse the repository at this point in the history

  2. First pass at restructuring the pixel <> world API 

    The goal of this refactoring is to be able to remove `Frame.coordinates`
and `Frame.coordinate_to_quantity` and rely on the Astropy WCSAPI
machinery to do those conversions.
    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    870286d View commit details
    Browse the repository at this point in the history

  3. Remove now unused methods 

    coordinates() and coordinate_to_quantity() are replaced by APE 14 methods
    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    6ccdfe0 View commit details
    Browse the repository at this point in the history

  4. Rewrite coordinate systems tests for APE 14 

    This highlights some API changes here.
    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    8e333f2 View commit details
    Browse the repository at this point in the history

  5. cleanup

    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    74b88fa View commit details
    Browse the repository at this point in the history

  6. Revert changes to inverse w/r/t with_units

    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    dc717ba View commit details
    Browse the repository at this point in the history

  7. Use is_high_level to detect input to inverse

    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    a199c43 View commit details
    Browse the repository at this point in the history

  8. Remove isnumerical

    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7694b11 View commit details
    Browse the repository at this point in the history

  9. Remove old test

    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    78af31e View commit details
    Browse the repository at this point in the history

  10. Remove unused imports

    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    5ae6f4c View commit details
    Browse the repository at this point in the history

  11. Fix doc build

    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    46b07cf View commit details
    Browse the repository at this point in the history

  12. Delete reference_position 

    Closes spacetelescope#436
    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    ef836af View commit details
    Browse the repository at this point in the history

  13. lint

    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    1b4a338 View commit details
    Browse the repository at this point in the history

  14. Add a test for axes ordering with CelestialFrame 

    fixes spacetelescope#269
    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    8026e87 View commit details
    Browse the repository at this point in the history

  15. Update gwcs/coordinate_frames.py

    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    6ec2d06 View commit details
    Browse the repository at this point in the history

  16. even more lint

    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    50e2340 View commit details
    Browse the repository at this point in the history

  17. Test different Units said Nadia 💥

    @Cadair
    Cadair committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    2e33bb2 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. First attempt at keeping a sorted and unsorted list of frame props

    @Cadair
    Cadair committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    e65454e View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. make tests pass, ecept slicing

    Nadia Dencheva committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    065d4ce View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. fix typo and run tests

    Nadia Dencheva committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    9b59a27 View commit details
    Browse the repository at this point in the history

  2. fix typo

    Nadia Dencheva committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    4b926d5 View commit details
    Browse the repository at this point in the history

  3. fix style

    Nadia Dencheva committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    4685bcd View commit details
    Browse the repository at this point in the history