Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Enforce C99 #473

Merged
merged 1 commit into from May 1, 2020
Merged

MNT: Enforce C99 #473

merged 1 commit into from May 1, 2020

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 2, 2020

Fix #472

Works for me but someone needs to check the waf syntax.

@pllim pllim requested review from jhunkeler and rendinam April 2, 2020 19:51
rendinam
rendinam approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@rendinam rendinam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows building on Linux systems with gcc 4.8.5. Thanks!

@pllim pllim merged commit 11b1be9 into spacetelescope:master May 1, 2020
@pllim pllim deleted the cflags-add-c99 branch May 1, 2020 15:42
@pllim pllim mentioned this pull request May 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rendinam rendinam rendinam approved these changes

@jhunkeler jhunkeler Awaiting requested review from jhunkeler

Assignees
No one assigned
Labels
bug build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C99 standard required but not enforced
2 participants
@pllim @rendinam