Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFC3 Time-dependent photometry update #518

Merged

Conversation

mdlpstsci
Copy link
Contributor

imphttab

  • Fixed an existing bug in getphttab.c by ensuring a string was set to
    the empty string. The bug would only be manifested for multiple Imsets
    in an input file, in conjunction with a parameterized value.
    wfc3
  • Added MJD as a parameterized variable for the PHOTMODE keyword to
    enable a time-dependent photometric correction for the UVIS only.
  • Removed appending "CAL" to the PHOTMODE keyword.

@mdlpstsci
Copy link
Contributor Author

The photometry algorithm has changed in a manner which is not backwards compatible to previous results. Once the algorithm has been vetted by the WFC3 team, new truth files will have to be generated.

@catherine-martlin
Copy link

@mdlpstsci - Just a note that I sent the UVIS IMPHTTAB that you needed in an email. Our testing of the updates went well and we're ready for the next steps.

@mdlpstsci
Copy link
Contributor Author

mdlpstsci commented Sep 18, 2020

On 18 September 2020 Catherine Martlin emailed:

Hi Matt and Michele,

Attached you’ll find the new UVIS IMPHTTAB to use with testing with the WFC3 code updates by Michele. We’ve finished our review of her updates and are happy with them and ready for the regression testing to start.

Please let me know if there is anything else you need from us to produce the regression test data – I’ll be the one looking at it once it’s ready for us to inspect.

Thanks! Best wishes,

Catherine

Michele downloaded the new file for inspection and testing.

- Fixed an existing bug in getphttab.c by ensuring a string was set to
  the empty string.  The bug would only be manifested for multiple Imsets
  in an input file, in conjunction with a parameterized value.
wfc3
- Added MJD as a parameterized variable for the PHOTMODE keyword to
  enable a time-dependent photometric correction for the UVIS only.
- Removed appending "CAL" to the PHOTMODE keyword.
Copy link
Contributor

@stsci-hack stsci-hack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me.

@mdlpstsci mdlpstsci merged commit e08676b into spacetelescope:master Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants