Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: HLA-1036: An 'MJD#' value is added to the PHOTMODE keyword in the PHDU #612

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

mdlpstsci
Copy link
Contributor

Add the 'MJD#' value to the PHOTMODE keyword in order to enable a time-dependent photometric correction for the IR. By adding the 'MJD#' value to the PHOTMODE keyword string value, the algorithm now must search the new IMPHTTAB file for a row whose first column, OBSMODE, matches the string. This supplements the change done previously for the UVIS in 2020.

time-dependent photometric correction for the IR.  This supplements
the change done previously for the UVIS in 2020.
@mdlpstsci mdlpstsci changed the title HLA-1036: An 'MJD#' value is added to the PHOTMODE keyword in the PHDU WIP: HLA-1036: An 'MJD#' value is added to the PHOTMODE keyword in the PHDU Apr 16, 2024
Copy link
Collaborator

@stscirij stscirij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - same as the corresponding code for ACS

@mdlpstsci mdlpstsci merged commit 0276e46 into spacetelescope:main Apr 19, 2024
3 checks passed
mdlpstsci added a commit to mdlpstsci/hstcal that referenced this pull request Jun 4, 2024
being prepared for a build.
Revert "WIP: HLA-1036: An 'MJD#' value is added to the PHOTMODE keyword in the PHDU (spacetelescope#612)"

This reverts commit 0276e46.
mdlpstsci added a commit that referenced this pull request Jun 4, 2024
being prepared for a build.
Revert "WIP: HLA-1036: An 'MJD#' value is added to the PHOTMODE keyword in the PHDU (#612)"

This reverts commit 0276e46.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants