Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cubeviz: Tabbed viewer is blank on initial selection #1677

Closed
rosteen opened this issue Sep 27, 2022 · 5 comments · Fixed by #1718
Closed

[BUG] Cubeviz: Tabbed viewer is blank on initial selection #1677

rosteen opened this issue Sep 27, 2022 · 5 comments · Fixed by #1718
Labels

Comments

@rosteen
Copy link
Collaborator

rosteen commented Sep 27, 2022

See the video below for a demonstration. Essentially, if you drag the second image viewer in Cubeviz to be tabbed inside the first viewer, when switching to the other viewer it will show as blank until something like a resize (of the viewer or browser) forces an update, at which point the data will display as expected. The expected behavior is that you can switch between viewer tabs and have the data display normally.

CC @maartenbreddels

Screen.Recording.2022-09-27.at.11.21.02.AM.mov
@mariobuikhuizen
Copy link
Collaborator

I've made a PR for bqplot for this: bqplot/bqplot#1531

@pllim
Copy link
Contributor

pllim commented Oct 11, 2022

@kecnry
Copy link
Member

kecnry commented Oct 11, 2022

@pllim there is a comment in #1718 that it is just a patch and can be removed when the bqplot fix is released.

@pllim
Copy link
Contributor

pllim commented Oct 11, 2022

For clarification, will #1718 break if we use it in conjunction with bqplot/bqplot#1531 ? That is, are the patches mutually exclusive and hence we need #1718 to pin a bqplot maxversion?

@mariobuikhuizen
Copy link
Collaborator

It will not break when the bqplot change is made, it will only cause an extra update event, which will subsequently be debounced.

mariobuikhuizen added a commit to mariobuikhuizen/jdaviz that referenced this issue Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants