Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default image viewer percentile to 95% #1386

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jun 9, 2022

Description

This pull request is to change the default percentile from min/max to 95% so typical astronomical images show better on load.

Fixes #577

Previous failed attempts:

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1386 (e1a0278) into main (8c3d3e7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1386   +/-   ##
=======================================
  Coverage   84.91%   84.91%           
=======================================
  Files          91       91           
  Lines        8288     8288           
=======================================
  Hits         7038     7038           
  Misses       1250     1250           
Impacted Files Coverage Δ
jdaviz/app.py 92.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c3d3e7...e1a0278. Read the comment docs.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, such a simple solution!

@kecnry kecnry merged commit b91701b into spacetelescope:main Jun 10, 2022
@pllim pllim deleted the brimful-of-percentile-on-the-95 branch June 10, 2022 13:14
@pllim
Copy link
Contributor Author

pllim commented Jun 10, 2022

I was surprised too. 😆 Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Imviz: Default percentile/constrast/bias should better show image details
3 participants