Add option of using self derived interpolated profile for horne extract in specviz2d/spectral extraction plugin #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshanahan1
requested review from
rosteen,
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay and
gibsongreen
as code owners
github-actions
bot
added
plugin
kecnry
reviewed
May 6, 2024
jdaviz/configs/specviz2d/plugins/spectral_extraction/spectral_extraction.py
Show resolved
Hide resolved
jdaviz/configs/specviz2d/plugins/spectral_extraction/spectral_extraction.vue
Show resolved
Hide resolved
jdaviz/configs/specviz2d/plugins/spectral_extraction/spectral_extraction.vue
Outdated
Show resolved
Hide resolved
pyproject.toml
Outdated
| "specreduce>=1.3.0,<1.4.0", | ||
| "specreduce@git+https://github.com/astropy/specreduce", |
There was a problem hiding this comment.
Should release of specreduce and pinning to it block merge here? Alternatively, we could have the feature dependent on a version check of specreduce without having to bump the min-pin?
There was a problem hiding this comment.
I'm +1 for release specreduce.
bmorris3
reviewed
May 17, 2024
pyproject.toml
Outdated
| "specreduce>=1.3.0,<1.4.0", | ||
| "specreduce@git+https://github.com/astropy/specreduce", |
There was a problem hiding this comment.
I'm +1 for release specreduce.
jdaviz/configs/specviz2d/plugins/spectral_extraction/tests/test_spectral_extraction.py
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
cshanahan1
force-pushed
the
spec_extract_self_profile
branch
from
e5c898d
to
bb683bd
Compare
kecnry
reviewed
May 31, 2024
| @@ -24,7 +24,7 @@ dependencies = [ | |||
| "voila>=0.4,<0.5", | |||
| "pyyaml>=5.4.1", | |||
| "specutils>=1.15", | |||
| "specreduce>=1.3.0,<1.4.0", | |||
| "specreduce>=1.4.0", | |||
There was a problem hiding this comment.
Should we exclude 1.5 now since we're allowing breaking changes still in specreduce?
Suggested change
| "specreduce>=1.4.0", | |
| "specreduce==1.4.*", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option of using a 'self profile' for Horne extraction to the spectral extraction plugin in Specviz2D.
This PR also bumps up specreduce to the most recent 1.4.0 which contains the relevant changes there.