Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide flux_unit from unit conversion #2846

Merged

Conversation

bmorris3
Copy link
Contributor

@bmorris3 bmorris3 commented May 3, 2024

Remove flux_unit from the unit conversion user API since we're likely to rename it.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@bmorris3 bmorris3 added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels May 3, 2024
@bmorris3 bmorris3 added this to the 3.10 milestone May 3, 2024
@github-actions github-actions bot added specviz plugin Label for plugins common to multiple configurations labels May 3, 2024
@bmorris3 bmorris3 enabled auto-merge May 3, 2024 14:47
@bmorris3 bmorris3 force-pushed the cubeviz-spec-extract-user-api branch from 265abdc to 71c8197 Compare May 3, 2024 15:29
@pllim
Copy link
Contributor

pllim commented May 3, 2024

Isn't this removing a feature? No change log?

@bmorris3
Copy link
Contributor Author

bmorris3 commented May 3, 2024

@pllim In the 3.10 release, the UI prevents the user from changing the value of this traitlet, and there's only one choice available anyway. Nothing is lost here.

@bmorris3 bmorris3 merged commit 83863e2 into spacetelescope:main May 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations specviz trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants