Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use small angular offsets when determining compass properties #2867

Merged
merged 2 commits into from
May 10, 2024

Conversation

astrofrog
Copy link
Collaborator

Description

While debugging an issue with GWCS coordinates with @bmorris3, I found that one issue is that if an image with a bounding box is used, and if we were to not reset the bounding box to None as we do currently in jadviz, the compass properties will fail in some cases - this is because before this PR, the pixel scale along the N and E directions was determined by adding 1 deg to the RA and Dec, but this is too large as this may then fall outside the image and return NaN (with spacetelescope/gwcs#497).

In any case, I think it makes sense to use small angular offsets when trying to do this calculation regardless of whether we decide to not disable the bounding box etc. I don't think there is any downside to using small offsets, and it will be more future-proof.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@github-actions github-actions bot added the imviz label May 10, 2024
@pllim pllim added this to the 3.11 milestone May 10, 2024
@pllim pllim added plugin Label for plugins common to multiple configurations no-changelog-entry-needed changelog bot directive labels May 10, 2024
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable and does fix the N-E arrows on ImvizDitheredExample notebook. Thanks!

@pllim
Copy link
Contributor

pllim commented May 10, 2024

There are 2 failures that just need their results updated.

@@ -98,18 +98,26 @@ def calc_compass(image_wcs, x, y, len_deg_e, len_deg_n):


def calc_compass_radius(image_wcs, x, y, radius_px):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ejeschke , this function was actually from ginga:

https://github.com/ejeschke/ginga/blob/7e61d9772ec1e57c332f1e2c0280d308972640c4/ginga/util/wcs.py#L762-L764

Are you interested to have a similar patch over at ginga?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like a good change, so sure!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK please see ejeschke/ginga#1102 . Thanks!

@pllim pllim added the trivial Only needs one approval instead of two label May 10, 2024
@pllim pllim enabled auto-merge May 10, 2024 22:39
@pllim pllim merged commit 37eba85 into spacetelescope:main May 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants