Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten metadata layout and improve grouping #2897

Merged
merged 2 commits into from
May 29, 2024

Conversation

haticekaratay
Copy link
Contributor

@haticekaratay haticekaratay commented May 29, 2024

Description

This pull request removes vertical spacing between key-value pairs and comments to tighten the layout and improve grouping visibility.
Before:
array data type

After:
image

Fixes #

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@haticekaratay haticekaratay added this to the 4.0 milestone May 29, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (ec80391) to head (be5b61f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2897   +/-   ##
=======================================
  Coverage   88.70%   88.70%           
=======================================
  Files         111      111           
  Lines       17123    17123           
=======================================
  Hits        15189    15189           
  Misses       1934     1934           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haticekaratay haticekaratay added the trivial Only needs one approval instead of two label May 29, 2024
@haticekaratay
Copy link
Contributor Author

@kecnry, should I ignore the Python 3.12 failure and merge? I know the failure isn't relevant to the changes I made.

@haticekaratay haticekaratay merged commit 609f16e into spacetelescope:main May 29, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants