Add voila dark mode #669
Closed
Add voila dark mode #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty sure it used to work. In fact, I enabled it in one of the early Imviz PR that was never merged because the white background was hurting my eyes as I did R&D. |
|
You are right. It no longer works. Maybe @maartenbreddels know why. |
|
@mariobuikhuizen could it be the template of jdaviz, I think the vue(tify) templates support it already right? |
|
Yeah, I will take a look. |
This was referenced Jun 15, 2021
|
I'll move this patch to #682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an attempt to do #415 , but not it does not work in that no dark mode is activated.
I'm just guessing this is because vue is not hooked up to whatever voila uses to signal dark mode? But it's curious it's not consistent with #665...
Opening as a draft because it doesn't work, but might be a good starting point for a later implementation