Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore int grp difference #1020

Merged
merged 10 commits into from
Aug 17, 2022
Merged

Explore int grp difference #1020

merged 10 commits into from
Aug 17, 2022

Conversation

BradleySappington
Copy link
Collaborator

Add ability to show integration and group specific images in explorer mode

@BradleySappington
Copy link
Collaborator Author

Initial front end work, no functionality at this point

@pep8speaks
Copy link

pep8speaks commented Aug 10, 2022 •
edited

Hello @BradleySappington, Thank you for updating !

Line 215:64: E226 missing whitespace around arithmetic operator
Line 1098:17: W503 line break before binary operator
Line 1099:17: W503 line break before binary operator
Line 1100:17: W503 line break before binary operator
Line 1101:17: W503 line break before binary operator
Line 1521:9: E722 do not use bare 'except'

Comment last updated at 2022-08-12 15:57:17 UTC

@BradleySappington
Copy link
Collaborator Author

@mfixstsci @bhilbert4 - Tested and Ready For Review

@BradleySappington BradleySappington self-assigned this Aug 12, 2022
@BradleySappington BradleySappington added this to In progress in v1.2.0 via automation Aug 12, 2022
@BradleySappington BradleySappington linked an issue Aug 12, 2022 that may be closed by this pull request
In Explorer Mode: Show Group/Iteration or difference between 2 groups/iterations #1002
Closed
@BradleySappington BradleySappington moved this from In progress to In Review in v1.2.0 Aug 15, 2022
@BradleySappington
Copy link
Collaborator Author

INTS GROUPS LINK
0 0 https://jwql-dev.stsci.edu/NIRSpec/jw02736005001_02101_00001_nrs2_rate/explore_image/
0 1
0 M
1 0 https://jwql-dev.stsci.edu/NIRSpec/jw02736005001_02101_00001_nrs2_rateints/explore_image/
1 1
1 M https://jwql-dev.stsci.edu/MIRI/jw01328015001_02105_00004_mirifushort_uncal/explore_image/
M 0 https://jwql-dev.stsci.edu/MIRI/jw01328015001_02105_00004_mirimage_rateints/explore_image/
M 1
M M https://jwql-dev.stsci.edu/MIRI/jw01328015001_02105_00004_mirimage_uncal/explore_image/

mfixstsci
mfixstsci approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BradleySappington, I tested and looked at the code and it looks great. Thanks for submitting this!

jwql/utils/interactive_preview_image.py Show resolved Hide resolved
jwql/utils/interactive_preview_image.py Show resolved Hide resolved
@mfixstsci mfixstsci merged commit cef9dc1 into spacetelescope:develop Aug 17, 2022
v1.2.0 automation moved this from In Review to Done Aug 17, 2022
@BradleySappington BradleySappington deleted the explore_int_grp_difference branch March 30, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfixstsci mfixstsci mfixstsci approved these changes

@bhilbert4 bhilbert4 Awaiting requested review from bhilbert4

Assignees

@BradleySappington BradleySappington

Labels
None yet
Projects
v1.2.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In Explorer Mode: Show Group/Iteration or difference between 2 groups/iterations
3 participants
@BradleySappington @pep8speaks @mfixstsci