Select anomaly name formatting #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfixstsci
reviewed
Oct 11, 2022
| @@ -81,16 +82,20 @@ | |||
| 'tree_rings': ['miri'], | |||
| # additional anomalies: | |||
| 'other': ['fgs', 'miri', 'nircam', 'niriss', 'nirspec']} | |||
| # anomalies that shouldn't be 'titleized' | |||
| special_cases = ['Dominant_MSA_Leakage','MRS_Glow','MRS_Zipper','LRS_Contamination'] | |||
There was a problem hiding this comment.
Love this approach, much cleaner. Thank you for submitting this @rcooper295
mfixstsci
approved these changes
Oct 11, 2022
|
@rcooper295 We have your branch on the test server but need to update the anomaly database. I am going to try and add some of the anomalies you added to the page to the database and then verify they are stored on the backend. Once that is done we have a couple of things lined up that will need to be merged before we can add this in. |
|
@rcooper295 @bhilbert4 Myself and @BradleySappington went ahead and updated the database column names and added the new anomaly data to the databases to see if they accepted submissions and everything looked good. This can be merged when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1018 by reformatting a few of the anomaly names to the desired case and treating them differently when the names are created for the checkboxes (don't use
inflection.titleize, just replace underscores with spaces).This requires some changes to the column names in the database. @BradleySappington made these on the dev database but @mfixstsci and/or @bhilbert4 should be aware that this will need to be done on the prod DB too before this change will work correctly.
The changes are:
('LRS_Contamination' was already capitalized correctly)