Proposal thumbnail search includes only proposal subdirectories #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mfixstsci simple tweak. Ready for review. |
mfixstsci
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Hey @bhilbert4 this looks good, I am always weary of globs with . or * as the search criteria. Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating proposal-level thumbnails, generate_proposal_thumbnails.py globs over the thumbnail system directory. However, it was searching for everything in this directory using a simple ''. This PR updates the search to look only for 'jw' entries, so that only the subdirectories containing the thumbnails are found. Logs from previous runs show that it was finding the text files in the same directory. This wasn't causing any real problem, since the next step is to search for files within each of the glob results, but it was leading to confusing log entries that seemed to indicate it was having trouble with the thumbnail list files.