New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edb mnemonic monitor rebase #1060
Edb mnemonic monitor rebase #1060
Conversation
Hooray it worked! So much easier than working manually one commit at a time on the command line. Items left to do:
|
@mfixstsci I want to remove the NIRISS entries that are causing plots to have way too many points and slowing the browser, but in terms of the code, this is finally finally ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of hard work here, thank you @bhilbert4 this looks great. A couple of comments and questions and then we can get this in. Thank you!
@bhilbert4 is all the testing for this PR finished? I am going to take a look on test and then merge if so. |
This PR is a test to get around problems with conflict resolution when rebasing the edb-mnemonic-monitor branch. I've added back the 3 MIRI data trending files that had recent updates, to hopefully remove them from the list of files with conflicts, in the hopes that the github conflict resolution button will come back. Eventually the data trending files need to be deleted, as they're not actually used.