Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow thumbnail files with multiple substrings to be kept #1064

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

bhilbert4
Copy link
Collaborator

This makes a modification to the function introduced by #1061. With this update, the function will delete all thumbnails whose names do not contain any of a list of substrings. Previously only a single substring was allowed.

Now we can keep thumbnails for "rate" and "dark" files. The thumbnails from the dark files is our one exception to the rule of making thumbnails only for rate files. That's because dark files don't get processed through the pipeline far enough to create rate files.

@bhilbert4 bhilbert4 self-assigned this Oct 26, 2022
@bhilbert4
Copy link
Collaborator Author

@mfixstsci @BradleySappington a small update to the function we merged earlier today. This is ready for review.

Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bhilbert4 these changes look good to me. Good catch including the dark file thumbnails, totally forgot about those.

@mfixstsci mfixstsci merged commit 25a419a into spacetelescope:develop Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants