Add Logging View #1080
Add Logging View #1080
Conversation
|
@BradleySappington or @bhilbert4 this is ready for a review when ready! |
|
|
||
| full_log_paths = sorted(glob.glob(os.path.join(log_path, server, '*', '*')), reverse=True) | ||
| full_log_paths = [log for log in full_log_paths if not os.path.basename(log).startswith('.')] | ||
| log_dictionary = {os.path.basename(path): path for path in full_log_paths} |
There was a problem hiding this comment.
Dictionary comprehension! I had forgotten that was a thing. :)
There was a problem hiding this comment.
This was super useful here.
jwql/website/apps/jwql/views.py
Outdated
|
|
||
| full_uri = request.build_absolute_uri() | ||
|
|
||
| if 'dljwql' in full_uri: |
There was a problem hiding this comment.
Do you think this is something that would be useful to have as its own general function somewhere, or is there not enough use for it to warrant a separate function?
There was a problem hiding this comment.
So this was causing the issue with the production logs being show on the test server. I went ahead and changed it to use the socket library to get the hostname of the machine rather than the URL.
| else: | ||
| server = 'ops' | ||
|
|
||
| full_log_paths = sorted(glob.glob(os.path.join(log_path, server, '*', '*')), reverse=True) |
There was a problem hiding this comment.
you may need more tests to verify you are on the correct server. "pljwql" is showing up on the test server.
There was a problem hiding this comment.
I went ahead and used a different library for this portion of the app. I have it working successfully now!
Adding page that will allow users to view logs interactively in the application.