Exposure page: Default to show rate img, keep order of radio buttons constant #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 16, 2022
|
@mfixstsci This is ready for review. I've tested on the dev server and everything looks good. rate images are shown upon page loads for all images except darks, where the dark suffix is shown. I've set up some logging that creates a log only if an unknown suffix is encountered. In my testing tonight so far, I haven't run into any instances of that. |
bhilbert4
changed the title
|
And the radio buttons listing the suffixes now appear in a consistent order from image to image. |
BradleySappington
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small adjustments such that the rate image is shown by default when clicking on the page for a given exposure. If there is n rate image, then it looks for a dark suffix.
There are also changes such that we try to keep the order of the radio buttons that list the available suffixes as consistent as possible, with the only changes coming from which suffixes are present.