Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions version to move from node12 to node16 #1137

Merged

Conversation

bhilbert4
Copy link
Collaborator

A test from a previous PR showed the warning:
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2

blog entry here: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

This PR makes the requeted update to the actions version

@bhilbert4 bhilbert4 self-assigned this Dec 19, 2022
@bhilbert4
Copy link
Collaborator Author

Tests are failing because they can't reach the MAST server. I'll try again in a bit.

@bhilbert4
Copy link
Collaborator Author

Tests are passing, and the warning about needing to switch to node16 is gone. https://github.com/spacetelescope/jwql/actions/runs/3732554173
@mfixstsci this is ready for review.

Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, looks like I should update my builds on my projects too.

@mfixstsci mfixstsci merged commit df5ba65 into spacetelescope:develop Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants