Improve bad pixel monitor plots #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order for this to work on the servers, we'll need to install the packages described in #1200. This is done on the test server and I didn't see any problems. |
bhilbert4
changed the title
|
@mfixstsci this is ready for review. |
mfixstsci
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Thanks for submitting this @bhilbert4 just a couple of comments here.
|
@bhilbert4 thanks for the responses, I am going to wait for the branch to rebase and then will merge the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove bokeh templating from the bad pixel monitor plots, and make some tweaks to make them more useful and faster to load.
I'm trying to make these a little more interactive than the plots from the dark monitor. In this case, the figure/plot creation will be called as the final step of the bad pixel monitor itself (or it can be called separately at any time). The output will be a separate html file for each instrument. Then when a user requests the bad pixel monitor page, it simply loads the html file.
Bokeh creates and saves the html file itself. There is then a bit of editing to place the relevant lines from that file into our jinja template. The bokeh lines can end up being quite long since they contain all of the plotted points and hover tools. So we sacrifice some speed there compared to the dark monitor plots, which are simply png files that are loaded and displayed. But in return for that we get more interesting/useful plots.