Update preview image generator to handle new NaN pixels #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this on all the examples listed in #1207, and the resulting jpg files look much cleaner. |
mfixstsci
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1207
A recent change in the cal pipeline now has pixels for which no slope is computed being set to NaN in the slope image. Previously these pixels had been set to zero. Setting these pixels to NaN means matplotlib now shows them as white in the preview images rather than black. This, combined with the way that matplotlib averages pixels together when producing the preview image/thumbnail jpgs was resulting in preview images that were full of white splotches. This PR updates the preview image generator such that NaN pixels are set to zero prior to creating jpgs. This means these pixels are back to being shown as black, and the matplotlib averaging seems not to creates big splotches when working with them.