Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all detectors #1213

Merged
merged 65 commits into from
Mar 20, 2023

Conversation

melanieclarke
Copy link
Collaborator

On the observation pages, there is now an option to group by exposure or file. For instruments with multiple detectors, grouping by exposure pulls up a page where previews from all simultaneous detector data are displayed together. From this page, you can mark an anomaly to apply to the whole group of files, or mark the whole group as Viewed. The preview images in the exposure group page are clickable: they will take you to the individual image page for that file, which works the way it always has.

For instruments with no simultaneous detectors, the exposure grouping is allowed, but has no real effect. The exposure pages have equivalent functionality to the existing image pages.

The archive date image page and JWQL query page also allow grouping by exposure.

@melanieclarke
Copy link
Collaborator Author

Note: PR #1197 should be merged before this one.

@melanieclarke melanieclarke changed the title WIP: Display all detectors Display all detectors Mar 14, 2023
Copy link
Collaborator

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and was a ton of work! I know the NIRCam team will be excited to be able to see all the detectors on a single page.
@mfixstsci I gave everything a look except for the js updates.

jwql/website/apps/jwql/data_containers.py Outdated Show resolved Hide resolved
jwql/website/apps/jwql/data_containers.py Show resolved Hide resolved
jwql/website/apps/jwql/data_containers.py Show resolved Hide resolved
jwql/website/apps/jwql/templates/archive.html Show resolved Hide resolved
jwql/website/apps/jwql/views.py Show resolved Hide resolved
jwql/website/apps/jwql/views.py Outdated Show resolved Hide resolved
jwql/tests/test_data_containers.py Show resolved Hide resolved
@bhilbert4 bhilbert4 linked an issue Mar 15, 2023 that may be closed by this pull request
Copy link
Collaborator

@BradleySappington BradleySappington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these changes are stylistic, this is a ton of great work!

One overall issue is that the default thumbnail (which I believe should be changed to imagenotfound.png) is not being used for your groups or files if the thumbnail does not exist.

Example here if loaded on test:
https://jwql-test.stsci.edu/NIRCam/archive/2057/obs003/

jwql/website/apps/jwql/static/js/jwql.js Outdated Show resolved Hide resolved
jwql/website/apps/jwql/static/js/jwql.js Outdated Show resolved Hide resolved
jwql/website/apps/jwql/static/js/jwql.js Outdated Show resolved Hide resolved
jwql/website/apps/jwql/static/js/jwql.js Show resolved Hide resolved
jwql/website/apps/jwql/static/js/jwql.js Outdated Show resolved Hide resolved
jwql/website/apps/jwql/static/js/jwql.js Show resolved Hide resolved
@mfixstsci
Copy link
Collaborator

Thank you for submitting this @melanieclarke and thank you @BradleySappington for the review. Merging!

@mfixstsci mfixstsci merged commit fa047e1 into spacetelescope:develop Mar 20, 2023
@melanieclarke melanieclarke deleted the display-all-detectors branch March 20, 2023 16:44
@melanieclarke melanieclarke self-assigned this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants