Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing dark monitor #1224

Merged
merged 4 commits into from
Mar 27, 2023

Conversation

bhilbert4
Copy link
Collaborator

Resolves #1223
Adds missing definition of xdim, ydim.

@bhilbert4 bhilbert4 self-assigned this Mar 20, 2023
@bhilbert4
Copy link
Collaborator Author

Checking on the test server, this seems to solve the problem.

@bhilbert4
Copy link
Collaborator Author

@mfixstsci this is ready for review. We should get this in before the meeting on Wednesday.

@bhilbert4 bhilbert4 changed the title [WIP]: Fix failing dark monitor Fix failing dark monitor Mar 22, 2023
Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mfixstsci
Copy link
Collaborator

@mfixstsci this is ready for review. We should get this in before the meeting on Wednesday.

Sorry for the late reply @bhilbert4 I just bypassed showing the dark monitor.

@mfixstsci
Copy link
Collaborator

@bhilbert4 Just tested this out on dev and it looks great!

@mfixstsci mfixstsci merged commit 0d300a2 into spacetelescope:develop Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark monitor page failing to load
2 participants