-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for sqlalchemy>=2, django>=3.2 #1234
Updates for sqlalchemy>=2, django>=3.2 #1234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @melanieclarke -- These changes look great. Thank you for handling them, I am happy with the getter/setting naming conventions you implemented and the updated ways we connect and interface with the database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
This pull request updates code for compatibility with SQLAlchemy > 2.0 and Django > 3.2. Both of these versions introduced backwards incompatibilities that affected the JWQL application.