Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bokeh Templating from Readnoise Monitor #1238

Merged
merged 13 commits into from
Oct 20, 2023

Conversation

mfixstsci
Copy link
Collaborator

No description provided.

@mfixstsci mfixstsci changed the title Remove Bokeh Templating from Readnoise Monitor WIP: Remove Bokeh Templating from Readnoise Monitor Apr 4, 2023
@pep8speaks
Copy link

pep8speaks commented Oct 2, 2023

Hello @mfixstsci, Thank you for updating !

Line 174:1: W293 blank line contains whitespace
Line 183:5: E303 too many blank lines (2)
Line 204:25: E126 continuation line over-indented for hanging indent
Line 206:25: E123 closing bracket does not match indentation of opening bracket's line
Line 208:91: E231 missing whitespace after ','

Comment last updated at 2023-10-20 15:18:36 UTC

@mfixstsci mfixstsci changed the title WIP: Remove Bokeh Templating from Readnoise Monitor Remove Bokeh Templating from Readnoise Monitor Oct 13, 2023
@mfixstsci
Copy link
Collaborator Author

@BradleySappington and @bhilbert4 this is ready for review (finally) 🎉

Copy link
Collaborator

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me. Only one comment really, just in multiple places.

Copy link
Collaborator

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mfixstsci mfixstsci merged commit 46d2548 into spacetelescope:develop Oct 20, 2023
6 checks passed
@mfixstsci mfixstsci deleted the remove-readnoise-bokeh branch October 20, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants