Nest the if statements to protect against empty file list #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mfixstsci this is ready for review. Just a few plot tweaks from @bsunnquist 's feedback, and breaking up a compound if statement into two nested if statements, in order to avoid the indexing error in the linked issue. |
|
I tested locally and on the test server, and all plots look good. |
mfixstsci
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1241
The bias monitor was crashing in a case where the database entry for the calibrated file name was empty. The check for this was in place, but incorrectly combined with a check that the given filename pointed to a real file. This PR splits those two conditions into two if statements, in order to correctly catch each issue.