Add Code Linter CI #1265
Add Code Linter CI #1265
Conversation
|
Hey @BradleySappington @bhilbert4 @melanieclarke here is the most recent run that ignores line to long errors. I think that some of these will need to be fixed but some of them will need to have https://github.com/spacetelescope/jwql/actions/runs/5059823979/jobs/9081903008?pr=1265 |
…c ray monitor and removing templating
…. Ruff can ignore
jwql/instrument_monitors/common_monitors/edb_telemetry_monitor_utils/condition.py
Show resolved
Hide resolved
jwql/website/apps/jwql/monitor_pages/monitor_readnoise_bokeh.py
Outdated
Show resolved
Hide resolved
|
@melanieclarke okay sorry for going silent on this for a while. All of your comments were addressed and added in all of the imports that are necessary. I wouldn't be surprised if we need to iterate again but this first round was a good start! |
|
@mfixstsci - your updates look good to me and local tests are passing. But there are some differences I don't understand between develop and this branch. It looks like some recent work from develop is missing from this branch -- the explore image and file download links for example. On the command line, merging develop in does not recover this work. Can you check your merge history for this branch? It's possible you might have overwritten changes from develop when resolving merge conflicts. |
|
Reopening in #1305. |
Adding ruff autolinter to repository.