-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
May/June Environment Updates #1267
May/June Environment Updates #1267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new environment files look good to me! Both of them build, look fine in spot checks, and mostly pass local testing.
Two things though...
- I think the requirements.txt and rtd-requirements.txt files need to be updated to match the updated dependency versions.
- There are a couple minor local testing issues related to the recent packaging changes (below). They're unrelated to the environment changes here, so I can add a separate PR for it if you want.
Testing issues:
- test_setup.py fails due to changes in the way versioning is done
- pyproject.toml is not setup correctly to exclude the static directory, so test discovery is not working right -- 'pytest jwql' attempts to recurse the entire filesystem to find unit tests.
Thanks for the review @melanieclarke! I forgot about the requirement files 😓 I will go ahead and update those. As for the the |
Still learning too! I don't know if this is the best way, but testing locally, it looks like it works. In pyproject.toml, remove the
|
@melanieclarke thanks, I went ahead and made the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks for the updates!
No description provided.