Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update anomaly search backend #1295

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

BradleySappington
Copy link
Collaborator

Now that we have a postgres DB, use union and intersect in standard backend query result filtering

@bhilbert4
Copy link
Collaborator

Does this mean we need to update this function as well?
https://github.com/spacetelescope/jwql/blob/develop/jwql/utils/monitor_utils.py#L225

@BradleySappington
Copy link
Collaborator Author

Does this mean we need to update this function as well? https://github.com/spacetelescope/jwql/blob/develop/jwql/utils/monitor_utils.py#L225

Nope! That looks great

Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BradleySappington this looks great.

jwql/website/apps/jwql/data_containers.py Show resolved Hide resolved
@mfixstsci
Copy link
Collaborator

@bhilbert4 I spoke with @BradleySappington about testing the code and he performed a couple of queries before and after merging his code in to verify the results were the same. Would you mind trying the same to verify since you are more familiar with the JWST data products. Once that is done, I can go ahead and merge it in!

@bhilbert4
Copy link
Collaborator

@BradleySappington @mfixstsci I just pulled this onto the dev server, restarted the service, and tried some queries. The results I'm getting back don't make any sense though. Is there something else I need to do to switch the dev server over to look at the correct database or something?

@BradleySappington
Copy link
Collaborator Author

@BradleySappington @mfixstsci I just pulled this onto the dev server, restarted the service, and tried some queries. The results I'm getting back don't make any sense though. Is there something else I need to do to switch the dev server over to look at the correct database or something?

Comment marking that this has been resolved

Copy link
Collaborator

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Spot tests on the dev server gave the expected results.

@mfixstsci mfixstsci merged commit db943ed into spacetelescope:develop Aug 18, 2023
6 checks passed
@BradleySappington BradleySappington deleted the query_enhance branch March 14, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants