Bias monitor failure from recent shared tasks update #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhilbert4
changed the title
bhilbert4
changed the title
|
Ok, I think this is working. My limited test using one nircam aperture worked well. I'm currently running a full test across all instruments and apertures, to be sure I'm not missing anything that is instrument-dependent. So far that test is running well (on the dev server), so I'm optimistic that everything will be fine. In the meantime, @mfixstsci I think this is ready for review. |
|
The full test on the dev server completed successfully, and the resulting bias monitor pages look good. Now officially ready for review. @mfixstsci |
mfixstsci
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bias monitor is failing after the recent shared tasks updates in #1262
One problem that popped up immediately is that the pipeline calls for the bias monitor appeared to be feeding the wrong short filename into the pipeline code. It turns out that the bias monitor extracts the 0th group from each input file and places it in a new file with the suffix _uncal_0thgroup.fits. Having the "0thgroup" string after uncal was screwing up the new line in shared tasks that was supposed to return the "short name" of the file (e.g. jw01068001001_02101_00001_nrcb2). This fixes that issue.
Still checking to see if there are any other fixes that need to be made.