Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Bokeh to Verison 3.3.0 #1391

Merged
merged 26 commits into from
Feb 6, 2024

Conversation

mfixstsci
Copy link
Collaborator

Remove bokeh template files/imports and bump bokeh version from 2.4.3 --> 3.3.0

@mfixstsci mfixstsci changed the base branch from test to develop November 13, 2023 21:26
@pep8speaks
Copy link

pep8speaks commented Nov 13, 2023

Hello @mfixstsci, Thank you for updating !

Line 994:92: W504 line break after binary operator
Line 995:15: E128 continuation line under-indented for visual indent
Line 1000:111: W504 line break after binary operator
Line 1141:98: W291 trailing whitespace
Line 1142:19: E128 continuation line under-indented for visual indent
Line 1149:98: W291 trailing whitespace
Line 1150:19: E128 continuation line under-indented for visual indent

Line 404:13: E123 closing bracket does not match indentation of opening bracket's line

Line 227:83: E231 missing whitespace after ','
Line 229:78: E231 missing whitespace after ','
Line 253:5: E303 too many blank lines (2)
Line 274:9: E265 block comment should start with '# '
Line 353:5: E303 too many blank lines (2)
Line 647:58: E225 missing whitespace around operator
Line 648:58: E225 missing whitespace around operator
Line 739:17: E303 too many blank lines (2)
Line 776:5: E303 too many blank lines (2)

Line 135:116: E502 the backslash is redundant between brackets
Line 136:9: E128 continuation line under-indented for visual indent
Line 137:9: E128 continuation line under-indented for visual indent
Line 138:9: E124 closing bracket does not match visual indentation
Line 150:22: E127 continuation line over-indented for visual indent
Line 151:61: E502 the backslash is redundant between brackets
Line 153:22: E124 closing bracket does not match visual indentation
Line 172:1: E303 too many blank lines (3)
Line 420:1: E303 too many blank lines (3)
Line 513:1: E303 too many blank lines (3)
Line 589:13: E265 block comment should start with '# '

Line 177:62: E231 missing whitespace after ','
Line 196:43: E225 missing whitespace around operator
Line 544:13: E265 block comment should start with '# '
Line 545:52: E261 at least two spaces before inline comment
Line 545:53: E262 inline comment should start with '# '
Line 582:9: E265 block comment should start with '# '
Line 685:37: E124 closing bracket does not match visual indentation
Line 743:43: E225 missing whitespace around operator
Line 754:105: E231 missing whitespace after ':'

Line 125:39: E128 continuation line under-indented for visual indent
Line 126:39: E128 continuation line under-indented for visual indent
Line 127:26: E128 continuation line under-indented for visual indent

Comment last updated at 2024-02-05 20:47:09 UTC

@mfixstsci
Copy link
Collaborator Author

@BradleySappington @bhilbert4 All of the tests are passing, I caught all of the little imports and updates to templating etc. Ready for review.

Copy link
Collaborator

@BradleySappington BradleySappington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Does this no longer support versions before 3?

jwql/bokeh_templating/factory.py Outdated Show resolved Hide resolved
@mfixstsci
Copy link
Collaborator Author

Looks good. Does this no longer support versions before 3?

Exactly, we are ending support for bokeh versions less than 3.0

Copy link
Collaborator

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple of cosmetic questions.

jwql/website/apps/jwql/bokeh_containers.py Outdated Show resolved Hide resolved
jwql/bokeh_templating/factory.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@mfixstsci mfixstsci merged commit bb44e1d into spacetelescope:develop Feb 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants