-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Bokeh to Verison 3.3.0 #1391
Conversation
… Readnoise plots are currently working
Hello @mfixstsci, Thank you for updating !
Comment last updated at 2024-02-05 20:47:09 UTC |
@BradleySappington @bhilbert4 All of the tests are passing, I caught all of the little imports and updates to templating etc. Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Does this no longer support versions before 3?
Exactly, we are ending support for bokeh versions less than 3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a couple of cosmetic questions.
Remove bokeh template files/imports and bump bokeh version from
2.4.3 --> 3.3.0