Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Crashing archive_database_update #1425

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

BradleySappington
Copy link
Collaborator

Archive Database Update is crashing with a key error when past does not return all values from a get_proposals_by_category call in data_containers.py

Add simple try except and logging

@pep8speaks
Copy link

pep8speaks commented Jan 10, 2024

Hello @BradleySappington, Thank you for updating !

Line 416:13: E128 continuation line under-indented for visual indent
Line 427:17: E128 continuation line under-indented for visual indent

Comment last updated at 2024-01-10 16:50:48 UTC

@BradleySappington
Copy link
Collaborator Author

@mfixstsci @bhilbert4 - Ready for review, verified all works on test

Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @BradleySappington thanks!

@mfixstsci mfixstsci merged commit 143b3ad into spacetelescope:develop Jan 10, 2024
6 checks passed
@BradleySappington BradleySappington deleted the adu_crash_hotfix branch January 10, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants