Anomaly naming

[BradleySappington]

NIRSPEC Only:
Guidestar Failure -> (remove)
Crosstalk -> (remove)
Data Transfer Error -> (remove)
(add) -> Transient Short
(add) -> Subsequently Masked Short
(add) -> Monitored Short
(add) -> Bright Object (not a short)

Snowball -> Unusual Snowballs - rename for all instruments
Dominant MSA Leakage -> Noticeable MSA Leakage rename for all instruments
Optical Short -> New Short rename for all instruments
Cosmic Ray Shower - keep as is for miri, remove option from other instruments
Unusual Cosmic Rays - create this for all non miri instruments, migrate existing cosmic ray shower values here
Scattered Light - Enable for Nirspec
(add) -> Needs Discussion to all

NOTE!! @mfixstsci and @bhilbert4 :
After releasing anomaly changes to production, Before Bringing back up the webapp, we need to manually update the table named jwql_anomalies for:
Unusual Cosmic Rays - created this for all non miri instruments, migrate existing cosmic ray shower values here
Scattered Light - Migrate Nirspec existing GHOST anomalies to this column

[pep8speaks]

Hello @BradleySappington, Thank you for updating !

• In the file jwql/tests/test_data_containers.py:

Line 38:1: E402 module level import not at top of file
Line 39:1: E402 module level import not at top of file
Line 42:1: E402 module level import not at top of file
Line 147:28: E128 continuation line under-indented for visual indent
Line 152:28: E128 continuation line under-indented for visual indent
Line 295:1: E302 expected 2 blank lines, found 1

Comment last updated at 2024-01-18 21:15:33 UTC

[BradleySappington]

https://jira.stsci.edu/browse/JWQL-155

[BradleySappington]

@bhilbert4 and @mfixstsci - I included a bug fix for our special case anomalies not being updated in DB. This PR should be prioritized and released as soon as reasonably possible. Its currently ready for review and testing

[melanieclarke]

@BradleySappington - are the changes up on a test server somewhere I can access?

[BradleySappington]

Not currently, only on my local Mesa2. If the code review passes I will merge to test for all to look at and try to break. I omitted the parens. And just said “Bright Object Not A Short”. If that’s not acceptable please let me know! From: Melanie Clarke ***@***.***> Reply-To: spacetelescope/jwql ***@***.***> Date: Thursday, January 18, 2024 at 4:32 PM To: spacetelescope/jwql ***@***.***> Cc: Bradley Sappington ***@***.***>, Mention ***@***.***> Subject: Re: [spacetelescope/jwql] Anomaly naming (PR #1435) @BradleySappington<https://urldefense.com/v3/__https:/github.com/BradleySappington__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!0kR-q-WOjf9m_De5HeGjYkT6dVr2LfmsvXlke9Z8vFzuQMFK5fkbUNglaBM2joZOtrB2AkiQuecjPBEGKqygfyi1SJYG$> - are the changes up on a test server somewhere I can access? — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/spacetelescope/jwql/pull/1435*issuecomment-1899235857__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!0kR-q-WOjf9m_De5HeGjYkT6dVr2LfmsvXlke9Z8vFzuQMFK5fkbUNglaBM2joZOtrB2AkiQuecjPBEGKqygf_7E-bBW$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AYEBMN6NXZGKNKFNMSR7NI3YPGIIRAVCNFSM6AAAAABCAOHCKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZGIZTKOBVG4__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!0kR-q-WOjf9m_De5HeGjYkT6dVr2LfmsvXlke9Z8vFzuQMFK5fkbUNglaBM2joZOtrB2AkiQuecjPBEGKqygfwrPvWnY$>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[melanieclarke]

Everything looks good to me! Bright Object Not A Short is clear enough.

[mfixstsci]

Thanks @BradleySappington!

[mfixstsci]

@BradleySappington, when we merge into the develop branch should we perform the same changes you listed above on the development servers database?

[BradleySappington]

@BradleySappington, when we merge into the develop branch should we perform the same changes you listed above on the development servers database?

Development database doesn't matter too much, so no, we dont need to transition anything there