Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIRCam Background Monitor updates #1440

Merged
merged 7 commits into from
Feb 5, 2024

Conversation

bsunnquist
Copy link
Collaborator

This PR makes the following changes based on NIRCam team feedback:

  • Incorporates the JWST background tool (JBT) predictions into the NIRCam Background Monitor (requires pip install jwst_backgrounds in jwql environment). This also requires two new columns in the NIRCamClawStats database (doy and total_bkg).
  • Plots 3 types of trending plots on the Background Monitor page, that you can tab between (see screenshot below): background levels, background rms, and background/model.
  • Expanded segmentation maps before calculating image statistics, mainly to allow for better rms calculations that aren't impacted by fainter source wings.
Screen Shot 2024-01-23 at 10 47 08 AM

@pep8speaks
Copy link

pep8speaks commented Jan 23, 2024

Hello @bsunnquist, Thank you for updating !

Line 171:121: W504 line break after binary operator
Line 172:107: W504 line break after binary operator
Line 300:17: E722 do not use bare 'except'
Line 439:17: E722 do not use bare 'except'

Comment last updated at 2024-02-02 18:43:12 UTC

@bhilbert4
Copy link
Collaborator

Could you add JBT to the environment files, requirements.txt, and (I think) setup.py?

@bsunnquist
Copy link
Collaborator Author

Added the JBT to the requirements - looks like the regression tests all ran OK. Most packages required by jwst_backgrounds were already in our jwql environment, with the exception of healpy.

@mfixstsci
Copy link
Collaborator

Thanks for this @bsunnquist looks like we have a conflict. Would you mind resolving it? Thank you!

@bsunnquist
Copy link
Collaborator Author

@mfixstsci merge conflict should be fixed now

@mfixstsci
Copy link
Collaborator

@mfixstsci merge conflict should be fixed now

Thank you @bhilbert4 I will go ahead and review!

Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bsunnquist this looks great. I am going to test it locally as well.

@mfixstsci
Copy link
Collaborator

Just finished local testing, thank you @bsunnquist everything looks good to me 👍

@mfixstsci mfixstsci merged commit c42f278 into spacetelescope:develop Feb 5, 2024
6 checks passed
@bsunnquist
Copy link
Collaborator Author

Thanks @mfixstsci ! Did you get those 2 new database columns working on the server (doy and total_bkg)? If so, I'll prepare a request to insert some historical data into those updated databases in a separate issue.

@mfixstsci
Copy link
Collaborator

As of right now, I don't believe the columns are there but the web application and figure generation were successful. We are meeting today to discuss the database changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants